Skip to content

Conversation

@jcheese1
Copy link

@jcheese1 jcheese1 commented Feb 22, 2025

CleanShot.2025-02-22.at.10.46.18.mp4

fixes #6195


PR-Codex overview

This PR focuses on enhancing the authentication process in the thirdweb library by introducing SiweOptions for the useConnectModal and updating the SignatureScreen component to handle the closing action. It also adds a BasicAuthHook for custom UI authentication.

Detailed summary

  • Added SiweOptions support in useConnectModal.
  • Updated SignatureScreen to include an optional onClose prop.
  • Implemented the BasicAuthHookPreview component for custom authentication UI.
  • Modified ModalPreview to integrate playgroundAuth for local storage-based authentication.
  • Enhanced useConnectModal to accept auth prop.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@jcheese1 jcheese1 requested review from a team as code owners February 22, 2025 01:47
@changeset-bot
Copy link

changeset-bot bot commented Feb 22, 2025

🦋 Changeset detected

Latest commit: e544f1e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
thirdweb Minor
@thirdweb-dev/wagmi-adapter Patch
thirdweb-login Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 22, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@vercel
Copy link

vercel bot commented Feb 22, 2025

@jcheese1 is attempting to deploy a commit to the thirdweb Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added Playground Changes involving the Playground codebase. packages SDK Involves changes to the thirdweb SDK labels Feb 22, 2025
@joaquim-verges joaquim-verges changed the title [SDK] Feature: Add SiweOptions for useConnectModal See Feb 22, 2025
@joaquim-verges joaquim-verges changed the title See [SDK] Feature: Add SiweOptions for useConnectModal Feb 22, 2025
@joaquim-verges joaquim-verges merged commit a19c0c9 into thirdweb-dev:main Feb 25, 2025
23 of 29 checks passed
@joaquim-verges joaquim-verges mentioned this pull request Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages Playground Changes involving the Playground codebase. SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SIWE for custom headless connect

2 participants